[Buildroot] [PATCH 1/1] libcap: only install shared version

[Thomas Petazzoni]

Hello,

On Tue,  8 May 2018 18:11:36 +0200, Fabrice Fontaine wrote:

> diff --git a/package/libcap/libcap.mk b/package/libcap/libcap.mk
> index 48c2cb3456..247fd8a58f 100644
> --- a/package/libcap/libcap.mk
> +++ b/package/libcap/libcap.mk
> @@ -20,8 +20,12 @@ LIBCAP_MAKE_TARGET = libcap.a libcap.pc
>  LIBCAP_MAKE_INSTALL_TARGET = install-static
>  else
>  LIBCAP_MAKE_TARGET = all
> +ifeq ($(BR2_SHARED_LIBS),y)
> +LIBCAP_MAKE_INSTALL_TARGET = install-shared
> +else
>  LIBCAP_MAKE_INSTALL_TARGET = install
>  endif
> +endif

I think we could use a clearer approach:

ifeq ($(BR2_STATIC_LIBS),y)
LIBCAP_MAKE_TARGET = libcap.a libcap.pc
LIBCAP_MAKE_INSTALL_TARGET = install-static
else if ($(BR2_SHARED_LIBS),y)
LIBCAP_MAKE_TARGET = all
LIBCAP_MAKE_INSTALL_TARGET = install-shared
else
LIBCAP_MAKE_TARGET = all
LIBCAP_MAKE_INSTALL_TARGET = install
endif

is a lot clearer to me.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com