[Buildroot] [PATCH v2 3/4] Makefile: check rootfs overlays with BR2_ROOTFS_MERGED_USR enabled

Carlos Santos casantos at datacom.ind.br
Mon May 7 13:28:38 UTC 2018


> From: "Thomas Petazzoni" <thomas.petazzoni at bootlin.com>
> To: "Carlos Santos" <casantos at datacom.ind.br>
> Cc: "buildroot" <buildroot at buildroot.org>, "Yann Morin" <yann.morin.1998 at free.fr>, "Thomas De Schampheleire"
> <thomas.de_schampheleire at nokia.com>, "Peter Korsgaard" <peter at korsgaard.com>
> Sent: Monday, May 7, 2018 10:10:02 AM
> Subject: Re: [Buildroot] [PATCH v2 3/4] Makefile: check rootfs overlays with BR2_ROOTFS_MERGED_USR enabled

> Hello,
> 
> On Mon, 7 May 2018 10:05:46 -0300 (BRT), Carlos Santos wrote:
> 
>> >>  	@$(foreach d, $(call qstrip,$(BR2_ROOTFS_OVERLAY)), \
>> >>  		$(call MESSAGE,"Copying overlay $(d)"); \
>> >> -		rsync -a --ignore-times --keep-dirlinks $(RSYNC_VCS_EXCLUSIONS) \
>> >> -			--chmod=u=rwX,go=rX --exclude .empty --exclude '*~' \
>> >> -			$(d)/ $(TARGET_DIR)$(sep))
>> >> +		$(call SYSTEM_RSYNC,$(d),$(TARGET_DIR))$(sep))
>> > 
>> > This specific chunk is not directly related to checking that overlays
>> > comply with the merged /usr rule, so shouldn't this be in a separate
>> > commit ?
>> 
>> It removes “--keep-dirlinks”, so becomes identical to the SYSTEM_RSYNC
>> logic, as observed by Peter Korsgaard in a previous message.
> 
> Agreed, but I don't see what it has to do with "check rootfs overlays
> with BR2_ROOTFS_MERGED_USR enabled".

Hum, well, agree.

[grumpy mode on]

-- 
Carlos Santos (Casantos) - DATACOM, P&D
“The greatest triumph that modern PR can offer is the transcendent 
success of having your words and actions judged by your reputation, 
rather than the other way about.” — Christopher Hitchens


More information about the buildroot mailing list