[Buildroot] [PATCH] host-mkpasswd: fix crash on Fedora 28 build host

[Arnout Vandecappelle]

On 02-05-18 20:23, Stefan Becker wrote:
> Yann, All,
> 
> On Wed, May 2, 2018 at 8:57 PM Yann E. MORIN <yann.morin.1998 at free.fr
> <mailto:yann.morin.1998 at free.fr>> wrote:
> 
> 
>     But what if the libxcrypt package is not installed? Since crypt is only
>     optional in POSIX, there is no guarantee that libxcrypt is even present
>     on a system, especially now that glibc has decided to no longer provide
>     it by default, and given that even --enable-obsolete-crypt does not even
>     declare _XOPEN_CRYPT...
> 
>  
> If crypt() is provided by libxcrypt instead of glibc, then this should be
> automatically handled by package dependencies, i.e.
> 
> $ rpm -q --provides libxcrypt
> ...
> libcrypt.so.1()(64bit)
> libcrypt.so.1(GLIBC_2.2.5)(64bit)
> libcrypt.so.1(OW_CRYPT_1.0)(64bit)
> libcrypt.so.1(XCRYPT_2.0)(64bit)
> $ rpm -q --whatrequires 'libcrypt.so.1()(64bit)' | wc -l
> 57
> $ rpm -q --whatrequires 'libcrypt.so.1(XCRYPT_2.0)(64bit)' | wc -l
> 26
> 
> The first one ensures that pre-F28 binaries still continue to work on Fedora 28.
> The latter ones have obviously been rebuilt against libxcrypt.so already.
> 
> As for the development stuff:
> 
> $ rpm -ql libxcrypt-devel
> /lib64/libcrypt.so
> /usr/include/crypt.h

 And in pre-F28 this header will be provided by glibc-devel, right?

 But so in practice we can assume that crypt.h is always present, so why not
include it unconditionally?


 BTW, how is this solved in upstream whois?

 Regards,
 Arnout


> ...
> $ rpm -q --provides libxcrypt-devel
> libxcrypt-devel = 4.0.0-5.fc28
> libxcrypt-devel(x86-64) = 4.0.0-5.fc28
> pkgconfig(libxcrypt) = 4.0.0
> $ rpm -q --whatrequires 'libxcrypt-devel(x86-64)'
> glibc-devel-2.27-8.fc28.x86_64
> 
> So at least on Fedora 28 this is handled in a backward compatible way, i.e. if I
> want to compile against glibc I also get libxcrypt-devel and therefore crypt.h.
> 
> In short: I updated 2 systems from F27 to F28 and automatically have libxcrypt
> and libxcrypt-devel available after the update. On the remaining F27 system I
> can see that libxcrypt isn't available at all, i.e. it is a new F28 feature.
> 
> Just my €0.02, Stefan
> 
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF