[Buildroot] [PATCH v4 3/9] package/pkg-generic: add the concept of extract dependency
Peter Korsgaard
peter at korsgaard.com
Sun Mar 25 15:40:05 UTC 2018
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at bootlin.com> writes:
> Extract dependencies are dependencies that must be ready before the
> extract step of a package, i.e for tools that are needed to extract
> packages themselves. Current examples of such tools are host-tar,
> host-lzip and host-xz.
> They are currently handled through DEPENDENCIES_HOST_PREREQ. However,
> this mechanism has a number of drawbacks:
> - First and foremost, because host-tar/host-lzip/host-xz are not
> listed in the dependencies of packages, the package infrastructure
> does not know it should rsync them in the context of per-package
> SDK.
> - Second, there is no dependency handling *between* them. I.e, we
> have no mechanism that says host-tar should be built before
> host-lzip, while it is in fact the case: if you need to build
> host-lzip, you need to extract a tarball, so you may need host-tar
> if your system tarball is not capable enough.
> For those reasons, it makes sense to add explicit support for "extract
> dependencies" in the package infrastructure, through the
> <pkg>_EXTRACT_DEPENDENCIES variable. It is unlikely this variable will
> ever be used by a package .mk file, but it will be used internally by
> the package infrastructure.
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> ---
> Changes since v3:
> - Fix typo in documentation noticed by Yann (use -> used)
> - Add Reviewed-by from Yann
> Changes since v2:
> - New patch
> ---
> docs/manual/adding-packages-generic.txt | 7 +++++++
> package/pkg-generic.mk | 8 +++++++-
> 2 files changed, 14 insertions(+), 1 deletion(-)
> diff --git a/docs/manual/adding-packages-generic.txt b/docs/manual/adding-packages-generic.txt
> index 521d6d50c7..194da00e67 100644
> --- a/docs/manual/adding-packages-generic.txt
> +++ b/docs/manual/adding-packages-generic.txt
> @@ -347,6 +347,13 @@ information is (assuming the package name is +libfoo+) :
> a similar way, +HOST_LIBFOO_DEPENDENCIES+ lists the dependencies for
> the current host package.
> +* +LIBFOO_EXTRACT_DEPENDENCIES+ lists the dependencies (in terms of
> + package name) that are required for the current target package to be
> + extracted. These depnedencies are guaranteed to be compiled and
s/depnedencies/dependencies/
Committed with that fixed, thanks.
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list