[Buildroot] [PATCH v2 1/5] package/speexdsp: new package

Peter Korsgaard peter at korsgaard.com
Tue Jun 12 09:18:29 UTC 2018


>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls at t-online.de> writes:

 > Quoting speex release notes from https://www.speex.org
 > "Speex 1.2rc2 and SpeexDSP 1.2rc2 are out
 >  December 6, 2014
 >  This release splits the speex codec library and the speex DSP library
 >  into separate source trees."

 > After bumping speex to 1.2.0 this new package is necessary to provide
 > speex-based DSP support.

 > Signed-off-by: Bernd Kuhls <bernd.kuhls at t-online.de>
 > ---
 > v2: no changes

 >  package/Config.in                             |   1 +
 >  .../0001-port-resample-neon-to-aarch64.patch  | 250 ++++++++++++++++++

This patch is not documented in the commit message?

 > +config BR2_PACKAGE_SPEEXDSP
 > +	bool "speexdsp"
 > +	help
 > +	  Speex is a patent-free audio codec designed especially for
 > +	  voice (unlike Vorbis which targets general audio) signals and
 > +	  providing good narrowband and wideband quality. This project
 > +	  aims to be complementary to the Vorbis codec.

That sounds like a description of speex (and not speexdsp) to me. Maybe
we should add the description from the git repo to this as well:

"DSP library derived from speex"

 > +################################################################################
 > +#
 > +# speexdsp
 > +#
 > +################################################################################
 > +
 > +SPEEXDSP_VERSION = 20ed3452074664ad07e380e51321b148acebdf20
 > +SPEEXDSP_SITE = https://git.xiph.org/speexdsp.git

Why are we using a git snapshot (and still backporting a patch on top)
and not the 1.2-rc3 release?

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list