[Buildroot] [PATCH 1/1] imx-gpu-viv: add a missing backslash

Peter Korsgaard peter at korsgaard.com
Fri Jul 20 11:47:21 UTC 2018


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at bootlin.com> writes:

Hi,

 >> A semicolon is also missing. I've changed it to do  '|| exit 1; \' like
 >> we do elsewhere to catch failures and committed, thanks.

 > Actually, in this sort of case, I would prefer to use a make for loop:

 > 	$(foreach lib,egl gbm glesv1_cm glesv2 vg, \
 > 		ln -sf $(lib)_x11.pc $(@D)/gpu-core/usr/lib/pkgconfig/$(lib).pc
 > 	)

 > make automatically aborts the loop if there's an error, and $(lib) is
 > more readable than $${lib}.

Correct. I left it like this as the file has several other shell loops.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list