[Buildroot] [PATCH 08/14] diffconfig: fix code style

Marcus Folkesson marcus.folkesson at gmail.com
Tue Jan 30 20:25:12 UTC 2018


Hi,

On Mon, Jan 29, 2018 at 11:11:52PM +0100, Thomas Petazzoni wrote:
> Hello,
> 
> On Sun, 21 Jan 2018 22:44:36 -0200, Ricardo Martincoski wrote:
> > Fix these warnings:
> > E225 missing whitespace around operator
> > E231 missing whitespace after ','
> > E302 expected 2 blank lines, found 1
> > E305 expected 2 blank lines after class or function definition, found 1
> > E401 multiple imports on one line
> > 
> > Signed-off-by: Ricardo Martincoski <ricardo.martincoski at gmail.com>
> > Cc: Marcus Folkesson <marcus.folkesson at gmail.com>
> 
> I haven't applied this one, because I don't really like the fact that
> we're further tweaking a script that comes from the kernel sources. On
> the other hand, we have already tweaked it for our purposes.
> 
> What do others think? Should we stay as close to the original upstream
> version as possible? Or because we have anyway already tweaked it, we
> don't really care and can now do whatever changes we believe are useful?

Well, I will try to keep the script reasonably synchronized between the
buildroot and kernel repo, and these type of patches does not really
help with that.

However, these scripts does not change that much, so I guess it does not
really matters.

> 
> Best regards,
> 
> Thomas
> -- 
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com


Best regards
Marcus Folkesson
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180130/b6d5af48/attachment.asc>


More information about the buildroot mailing list