[Buildroot] [PATCH] scanpypi: ignore empty elements in package requirements

Yegor Yefremov yegorslists at googlemail.com
Fri Jan 26 12:48:36 UTC 2018


On Fri, Jan 26, 2018 at 1:43 PM, Peter Korsgaard <peter at korsgaard.com> wrote:
>>>>>> "yegorslists" == yegorslists  <yegorslists at googlemail.com> writes:
>
>  > From: Yegor Yefremov <yegorslists at googlemail.com>
>  > Depending on how setup.py reads requirements files empty elements can occur.
>  > This patch takes care, that such elements will be ignored and don't crash
>  > the scanpypi script.
>
>  > Signed-off-by: Yegor Yefremov <yegorslists at googlemail.com>
>  > ---
>  >  utils/scanpypi | 4 +++-
>  >  1 file changed, 3 insertions(+), 1 deletion(-)
>
>  > diff --git a/utils/scanpypi b/utils/scanpypi
>  > index d043135..7392c50 100755
>  > --- a/utils/scanpypi
>  > +++ b/utils/scanpypi
>  > @@ -299,7 +299,9 @@ class BuildrootPackage():
>  >                          for req in self.pkg_req]
>
>  >          # get rid of commented lines and also strip the package strings
>  > -        self.pkg_req = [item.strip() for item in self.pkg_req if item[0] != '#']
>  > +        print("Req: {}".format(self.pkg_req))
>
> What is this print for? Just debugging? Did you mean to add it?

You're right. It was for debugging. I'll send v2.

Yegor


More information about the buildroot mailing list