[Buildroot] [PATCH 3/3] armbian-firmware: fail build for missing file
Peter Korsgaard
peter at korsgaard.com
Mon Jan 15 20:11:28 UTC 2018
>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski at gmail.com> writes:
> When a file is listed to be installed but is missing from the package
> source currently the first tar command exits with error code but it is
> ignored and the build succeeds.
> This issue by itself is minor because those listed files that are
> present in the package source get installed to the target.
> But the code is currently error prone, e.g. to a typo in the file list.
> Fix this by first creating a tarball in the build directory and then
> installing it, instead of using a pipe between the two tar invocations.
> Also use && between the commands, so the first command that exits with
> error code fails the build.
> Since the two tar invocations remain in use, the desired behavior
> remains the same:
> - list of files can contain *;
> - list of files can contain file inside path, and the path is then
> replicated in the target;
> - symlinks are not followed but are installed.
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski at gmail.com>
> Cc: Sergey Matyukevich <geomatsi at gmail.com>
> ---
> This package copied the install commands from linux-firmware.
> So let's copy the fix and also the commit log.
Committed, thanks.
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list