[Buildroot] [PATCH 1/3] linux-firmware: fail build for missing file

Peter Korsgaard peter at korsgaard.com
Mon Jan 15 20:05:51 UTC 2018


>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski at gmail.com> writes:

 > When a file is listed to be installed but is missing from the package
 > source currently the first tar command exits with error code but it is
 > ignored and the build succeeds.
 > This issue by itself is minor because those listed files that are
 > present in the package source get installed to the target.
 > But the code is currently error prone, e.g. to a typo in the file list.

 > Fix this by first creating a tarball in the build directory and then
 > installing it, instead of using a pipe between the two tar invocations.
 > Also use && between the commands, so the first command that exits with
 > error code fails the build.
 > Since the two tar invocations remain in use, the desired behavior
 > remains the same:
 >  - list of files can contain *;
 >  - list of files can contain file inside path, and the path is then
 >    replicated in the target;
 >  - symlinks are not followed but are installed.

 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski at gmail.com>
 > Cc: Fabio Estevam <festevam at gmail.com>
 > Cc: Peter Korsgaard <peter at korsgaard.com>
 > Cc: Peter Seiderer <ps.report at gmx.net>
 > Cc: Yann E. MORIN <yann.morin.1998 at free.fr>
 > Cc: Yegor Yefremov <yegorslists at googlemail.com>
 > ---
 > Should it go to 2017.11.x and 2017.08.x too? See next patch

Committed, thanks.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list