[Buildroot] [PATCH v3 1/1] opentracing-cpp: new package

Baruch Siach baruch at tkos.co.il
Wed Jan 3 09:50:32 UTC 2018


Hi Jan,

On Wed, Jan 03, 2018 at 10:07:51AM +0100, Jan Heylen wrote:
> I copied that infra from another package. Thomas also indicated already
> that there is something already generalised but not fully yet. So he
> adviced to keep it like this for the time being. If this is not nok, please
> advice differently.

I see that rabbitmq-c is also doing that. I think that the -DBUILD_SHARED_LIBS 
part is redundant. But the -DBUILD_STATIC_LIBS part might be needed, since the 
generic code does not handle that.

baruch

> On 3 Jan 2018 10:04, "Baruch Siach" <baruch at tkos.co.il> wrote:
> > On Wed, Jan 03, 2018 at 09:52:23AM +0100, Jan Heylen wrote:
> > > From: Jan Heylen <jan.heylen at nokia.com>
> > >
> > > Signed-off-by: Jan Heylen <jan.heylen at nokia.com>
> > > ---
> >
> > [...]
> >
> > > diff --git a/package/opentracing-cpp/opentracing-cpp.mk
> > b/package/opentracing-cpp/opentracing-cpp.mk
> > > new file mode 100644
> > > index 0000000..9b2d473
> > > --- /dev/null
> > > +++ b/package/opentracing-cpp/opentracing-cpp.mk
> > > @@ -0,0 +1,22 @@
> > > +###########################################################
> > #####################
> > > +#
> > > +# opentracing-cpp
> > > +#
> > > +###########################################################
> > #####################
> > > +
> > > +OPENTRACING_CPP_VERSION = v1.2.0
> > > +OPENTRACING_CPP_SITE = $(call github,opentracing,
> > opentracing-cpp,$(OPENTRACING_CPP_VERSION))
> > > +OPENTRACING_CPP_LICENSE = MIT
> > > +OPENTRACING_CPP_LICENSE_FILES = COPYING
> > > +
> > > +OPENTRACING_CPP_INSTALL_STAGING = YES
> > > +
> > > +ifeq ($(BR2_STATIC_LIBS),y)
> > > +OPENTRACING_CPP_CONF_OPTS += -DBUILD_SHARED_LIBS=OFF
> > -DBUILD_STATIC_LIBS=ON
> > > +else ifeq ($(BR2_SHARED_STATIC_LIBS),y)
> > > +OPENTRACING_CPP_CONF_OPTS += -DBUILD_SHARED_LIBS=ON
> > -DBUILD_STATIC_LIBS=ON
> > > +else ifeq ($(BR2_SHARED_LIBS),y)
> > > +OPENTRACING_CPP_CONF_OPTS += -DBUILD_SHARED_LIBS=ON
> > -DBUILD_STATIC_LIBS=OFF
> > > +endif
> >
> > The -DBUILD_SHARED_LIBS setting should be handled correctly by the
> > Buildroot
> > cmake infrastructure at package/pkg-cmake.mk. Doesn't that work for you?
> >
> > baruch
> >
> > > +
> > > +$(eval $(cmake-package))

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -


More information about the buildroot mailing list