[Buildroot] [git commit] qt5wayland: fix build issue with mesa3d w/out xcb

Peter Korsgaard peter at korsgaard.com
Wed Feb 28 06:32:05 UTC 2018


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at bootlin.com> writes:

 > Hello,
 > On Tue, 27 Feb 2018 21:48:17 +0100, Peter Korsgaard wrote:

 >> +# The mesa's EGL/eglplatform.h header includes X11 headers unless the flag
 >> +# MESA_EGL_NO_X11_HEADERS is defined. Tell to not include X11 headers if
 >> +# the libxcb is not selected.
 >> +ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_EGL)x$(BR2_PACKAGE_LIBXCB),yx)
 >> +QT5WAYLAND_QMAKEFLAGS += QMAKE_CXXFLAGS+=-DMESA_EGL_NO_X11_HEADERS
 >> +endif

 > I should have replied to the patch, but: I'm not happy with this
 > change. Indeed this -D flag should be part of mesa's pkg-config files,
 > and be picked up by Qt.

 > The simple fact that this identical fix had to be added to qt5wayland,
 > qt5webkit and qt5multimedia is a good indication that the fix is not
 > the appropriate one. We may have to replicate this fix to lots of other
 > qt5 packages.

 > So the right fix is to propagate the flag using pkg-config.

Yes, you had already discussed this on IRC and I agree, but that fix
does not look like it will be ready in time for 2018.02, so I've added
these fixes for now.

But indeed, please continue to work on the real upstreamable pkg-config
fix.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list