[Buildroot] [PATCH 2/3] package/strace: add missing libunwind optional dependency
Thomas De Schampheleire
patrickdepinguin at gmail.com
Sun Feb 25 20:28:19 UTC 2018
Hi,
2018-02-25 19:34 GMT+01:00 Romain Naour <romain.naour at gmail.com>:
> This improve the reproducible build.
>
> Signed-off-by: Romain Naour <romain.naour at gmail.com>
> ---
> package/strace/strace.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/package/strace/strace.mk b/package/strace/strace.mk
> index e292c60f2a..9c1fab3871 100644
> --- a/package/strace/strace.mk
> +++ b/package/strace/strace.mk
> @@ -10,6 +10,13 @@ STRACE_SITE = https://github.com/strace/strace/releases/download/v$(STRACE_VERSI
> STRACE_LICENSE = BSD-3-Clause
> STRACE_LICENSE_FILES = COPYING
>
> +ifeq ($(BR2_PACKAGE_LIBUNWIND),y)
> +STRACE_DEPENDENCIES += libunwind
> +STRACE_CONF_OPTS += --with-libunwind
> +else
> +STRACE_CONF_OPTS += --without-libunwind
> +endif
> +
As far as I know, the main (only?) reason for a libunwind dependency
is to support 'strace -k' to get callstack info. Perhaps it would be
useful to update the Config.in file to hint about this, i.e. that
users should enable libunwind manually if they want 'strace -k'
support.
In our local tree, I had added a config option to strace for that, but
perhaps that is overkill?
/Thomas
More information about the buildroot
mailing list