[Buildroot] unsafe header/library path used in cross-compilation: '-I/usr/include/readline'

[Baruch Siach]

Hi Sjoerd Venema,

On Sun, Feb 25, 2018 at 01:03:03AM +0100, Sjoerd Venema wrote:
> Ok, but package BR2_PACKAGE_READLINE is actually selected. Still, I get the
> error.
> I'm now running a make clean all, to be sure, but I don't think it resolves
> the issue. This is my .mk file:
> 
> ################################################################################
> #
> # ecasound
> #
> ################################################################################
> 
> ECASOUND_VERSION = 2.9.1
> ECASOUND_SOURCE = ecasound-$(ECASOUND_VERSION).tar.gz
> ECASOUND_SITE = http://ecasound.seul.org/download
> ECASOUND_INSTALL_STAGING = NO
> ECASOUND_INSTALL_TARGET = YES
> #ECASOUND_CONF_OPTS =
> ECASOUND_DEPENDENCIES = readline
> 
> $(eval $(autotools-package))

Unfortunately the ecasound build systems is not cross compile friendly. It 
insists on looking for readline.h in the host include directory. The quick 
hack below might help. Make sure to add _AUTORECONF to regenerate the 
Makefile.

This does not fix the cross compile issue completely, since ecasound still 
depends on readline headers being installed on your host, otherwise configure 
failes.

diff --git a/ecasound/Makefile.am b/ecasound/Makefile.am
index 9378d40ecb10..d2e58ab6e50c 100644
--- a/ecasound/Makefile.am
+++ b/ecasound/Makefile.am
@@ -1,4 +1,4 @@
-AM_CPPFLAGS = -I$(ECA_S_READLINE_INCLUDES) -I$(srcdir) -I$(top_srcdir) -I$(top_srcdir)/libecasound -I$(top_srcdir)/kvutils
+AM_CPPFLAGS = -I=/readline -I$(srcdir) -I$(top_srcdir) -I$(top_srcdir)/libecasound -I$(top_srcdir)/kvutils
 
 if ECA_AM_USE_NCURSES
 termcap_library_ncurses = -lncurses

baruch

> On 24 February 2018 at 22:25, Baruch Siach <baruch at tkos.co.il> wrote:
> > On Sat, Feb 24, 2018 at 10:12:19PM +0100, Sjoerd Venema wrote:
> > > I'm getting an "unsafe header/library path used in
> > cross-compilation"-error
> > > while building ecasound (https://ecasound.seul.org/ecasound/download.php
> > ).
> > > From what I've read so far is that it's because the makefile references
> > the
> > > /usr/-directory. What I can't figure out is how to change the makefile to
> > > not do that. Turning on/off the "paranoid"-function in menuconfig didn't
> > > make a difference.
> >
> > There is no ecasound package in current Buildroot. Have you added this
> > package
> > locally?
> >
> > > [buildroot at br buildroot]$ make ecasound
> > > >>> ecasound 2.9.1 Building
> > > PATH="/home/buildroot/buildroot-2018.02-rc2/output/
> > host/bin:/home/buildroot/buildroot-2018.02-rc2/output/
> > host/sbin:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin:
> > /home/buildroot/.local/bin:/home/buildroot/bin"
> > > /usr/bin/make -j5  -C
> > > /home/buildroot/buildroot-2018.02-rc2/output/build/ecasound-2.9.1/
> > > /usr/bin/make  all-recursive
> > > Making all in kvutils
> > > make[4]: Nothing to be done for `all'.
> > > Making all in libecasound
> > > Making all in plugins
> > > make[5]: Nothing to be done for `all'.
> > > make[5]: Nothing to be done for `all-am'.
> > > Making all in ecasound
> > > /home/buildroot/buildroot-2018.02-rc2/output/host/bin/
> > arm-buildroot-linux-uclibcgnueabihf-g++
> > > -DHAVE_CONFIG_H -I. -I. -I.. *-I/usr/include/readline* -I. -I..
> > > -I../libecasound -I../kvutils -D_REENTRANT -D_XOPEN_SOURCE=600
> > > -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64
> > > -ffast-math -fstrict-aliasing -DNDEBUG -DENABLE_DBC -D_LARGEFILE_SOURCE
> > > -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os  -c -o eca-curses.o
> > > eca-curses.cpp
> > > arm-buildroot-linux-uclibcgnueabihf-g++: WARNING: unsafe header/library
> > > path used in cross-compilation: '*-I/usr/include/readline*'
> >
> > This is just a warning, it doesn't break your build. But you should fix it.
> >
> > The BR2_COMPILER_PARANOID_UNSAFE_PATH option makes this a hard error. But
> > the
> > warning is shown anyway.
> >
> > > eca-curses.cpp:46:22: fatal error: readline.h: No such file or directory
> > >  #include <readline.h>
> > >                       ^
> >
> > This is your problem. Your package need readline. You need to select
> > BR2_PACKAGE_READLINE, as well as add readline to your package dependencies.
> >
> > > compilation terminated.
> > > make[4]: *** [eca-curses.o] Error 1
> > > make[3]: *** [all-recursive] Error 1
> > > make[2]: *** [all] Error 2
> > > make[1]: ***
> > > [/home/buildroot/buildroot-2018.02-rc2/output/build/
> > ecasound-2.9.1/.stamp_built]
> > > Error 2
> > > make: *** [_all] Error 2
> >
> > baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -