[Buildroot] [PATCH v2 1/3] package/llvm: new host package
Thomas Petazzoni
thomas.petazzoni at bootlin.com
Mon Feb 19 20:22:13 UTC 2018
Hello,
I have by far not reviewed everything, but noticed one problem.
On Mon, 19 Feb 2018 18:18:03 +0100, Valentin Korenblit wrote:
> +# Get target architecture
> +HOST_LLVM_TARGET_ARCH = $(call qstrip,$(BR2_PACKAGE_LLVM_TARGET_ARCH))
BR2_PACKAGE_LLVM_TARGET_ARCH does not exist, it is created by PATCH
2/3. This is not good, as it breaks bisectability.
Basically, your series should work even if we apply only PATCH 1/3. Or
if we apply only PATCH 1/3 and 2/3, etc.
So using in PATCH 1/3 something that is introduced in PATCH 2/3 is not
good.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
More information about the buildroot
mailing list