[Buildroot] [PATCH v2 1/2] network-manager: Bump to version 1.10.2

Peter Korsgaard peter at korsgaard.com
Sat Feb 3 22:24:38 UTC 2018


>>>>> "Petr" == Petr Vorel <petr.vorel at gmail.com> writes:

 > Hi Thomas,
 >> > +ifeq ($(BR2_PACKAGE_JANSSON),y)
 >> > +NETWORK_MANAGER_CONF_OPTS += --enable-ovs
 >> > +NETWORK_MANAGER_DEPENDENCIES += jansson
 >> > +else
 >> > +NETWORK_MANAGER_CONF_OPTS += --disable-ovs
 >> > +endif

 >> It is somewhat weird to introduce this here, and then add an explicit
 >> option in a second patch.
 > Oh, you're right.

 >> Perhaps PATCH 1/2 could just do --disable-ovs unconditionally, and
 >> PATCH 2/2 add the rest. If you agree, I can rework locally before
 >> applying, I understand it's a lot of nitpicking for such a small
 >> change :)
 > OK, please do it as I'm on a way to Fosdem, so I'd do it next week.
 > Thanks!

Committed both after reworking as suggested by Thomas, thanks.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list