[Buildroot] [PATCH 1/1] ltp-testsuite: Add upstream patch to fix build numa detection

[Baruch Siach]

Hi Petr,

On Thu, Feb 01, 2018 at 11:19:51PM +0100, Petr Vorel wrote:
> > On Mon, Jan 29, 2018 at 09:23:14PM +0100, Petr Vorel wrote:
> > > This removes fix added in commit 3c937807a3 ("ltp-testsuite: disable numa tests")
> 
> > > Signed-off-by: Petr Vorel <petr.vorel at gmail.com>
> > > ---
> > >  ...x-numa-v2-detection-for-cross-compilation.patch | 37 ++++++++++++++++++++++
> > >  package/ltp-testsuite/ltp-testsuite.mk             |  3 +-
> > >  2 files changed, 38 insertions(+), 2 deletions(-)
> > >  create mode 100644 package/ltp-testsuite/0002-numa-Fix-numa-v2-detection-for-cross-compilation.patch
> 
> > [...]
> 
> > > diff --git a/package/ltp-testsuite/ltp-testsuite.mk b/package/ltp-testsuite/ltp-testsuite.mk
> > > index 28dc24749e..87854568d8 100644
> > > --- a/package/ltp-testsuite/ltp-testsuite.mk
> > > +++ b/package/ltp-testsuite/ltp-testsuite.mk
> > > @@ -56,8 +56,7 @@ LTP_TESTSUITE_CONF_ENV += \
> > >  	CFLAGS="$(LTP_TESTSUITE_CFLAGS)" \
> > >  	CPPFLAGS="$(LTP_TESTSUITE_CPPFLAGS)" \
> > >  	LIBS="$(LTP_TESTSUITE_LIBS)" \
> > > -	SYSROOT="$(STAGING_DIR)" \
> > > -	have_numa_headers=no
> > > +	SYSROOT="$(STAGING_DIR)"
> 
> > >  # Requires uClibc fts and bessel support, normally not enabled
> > >  ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
> 
> > You should also make numactl an optional dependency to make the build more 
> > reproducible.
> 
> Can you be more specific, what you mean? numactl is required as a command in numa based
> tests (used by testcases/kernel/numa/numa01.sh). But that's not build dependency, it's a
> runtime dependency.

numactl is also an optional build time dependency of ltp-testsuite. When the 
ltp-testsuite configure script detects libnuma some additional tests are 
built. Currently when the numactl package is enabled, ltp-testsuite would 
detect libnuma only if numactl happens to build before ltp-testsuite. To make 
builds consistent we need to make sure that numactl always build before 
ltp-testsuite by adding it to _DEPENDENCIES. Here is how the hwloc package 
does that:

ifeq ($(BR2_PACKAGE_NUMACTL),y)
HWLOC_CONF_OPTS += --enable-libnuma
HWLOC_DEPENDENCIES += numactl
else
HWLOC_CONF_OPTS += --disable-libnuma
endif

ltp-testsuite needs something similar.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -