[Buildroot] [PATCH 1/1] package/grpc: add explicitly link with libatomic

Thomas Petazzoni thomas.petazzoni at bootlin.com
Mon Dec 31 14:54:59 UTC 2018


Hello,

On Fri,  7 Dec 2018 11:12:41 -0600, Ryan Barnett wrote:
> On some architectures, you must link with libatomic, on some other
> architectures, they are available built-in, but in all cases, linking
> against libatomic does not harm.
> 
> Fixes:
>   http://autobuild.buildroot.org/results/2f2/2f208fbfe4e9da94be5b9c030dbd278cb8ba053c/
> 
> Signed-off-by: Ryan Barnett <ryan.barnett at rockwellcollins.com>

It's a bit more complicated than that:

 - If it uses atomic built-ins, one needs to "depends on
   BR2_TOOLCHAIN_HAS_ATOMIC"

 - It can also use sync builtins.

So I've fixed that up, and applied your patch with the following
changes:

    [Thomas:
     - add the dependency on sync or atomic builtins in Config.in
     - use -DCMAKE_EXE_LINKER_FLAGS instead of
       -DCMAKE_C_STANDARD_LIBRARIES, to be consistent with what we do in
       some other cmake-based packages
     - tweak commit log]

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list