[Buildroot] [RFC 2/3] wpebackend-fdo: new package

Thomas Petazzoni thomas.petazzoni at bootlin.com
Mon Dec 31 14:02:05 UTC 2018


Hello Adrian,

Thanks for the review!

On Fri, 28 Dec 2018 01:58:02 +0100, Adrian Perez de Castro wrote:

> > diff --git a/package/wpebackend-fdo/Config.in b/package/wpebackend-fdo/Config.in
> > new file mode 100644
> > index 000000000..9025834e1
> > --- /dev/null
> > +++ b/package/wpebackend-fdo/Config.in
> > @@ -0,0 +1,17 @@
> > +comment "wpebackend-fdo needs an OpenEGL-capable backend"
> > +	depends on !BR2_PACKAGE_HAS_LIBEGL
> > +  
> 
> The dependency line for the comment needs to be updated to be the reverse
> of the list of dependencies for the BR2_PACKAGE_WPEBACKEND_FDO symbol below.
> 
> Also, the comment text should follow the Buildroot style:
> 
>     foo needs a toolchain w/ featA, featB, featC

Actually this form applies to toolchain features. For something like
OpenGL, we do use a comment similar to what François has used. See:

$ git grep "comment.*OpenGL"

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list