[Buildroot] [v3] package/mosquitto: installing the mosquitto broker can be optional

[Peter Korsgaard]

>>>>> "Titouan" == Titouan Christophe <titouan.christophe at railnova.eu> writes:

 > The mosquitto package provides both the MQTT client library and
 > a broker, and the latter may be not needed (when connecting to
 > a remote broker). It should be therefore possible to not install and
 > start it on the target

 > Signed-off-by: Titouan Christophe <titouan.christophe at railnova.eu>
 > ---
 > Changes v1->v2:
 >     * Remove a useless patch to modify mosquitto's Makefile
 >     * Change the setting name from BR2_PACKAGE_MOSQUITTO_INSTALL_BROKER
 >                                 to BR2_PACKAGE_MOSQUITTO_BROKER
 >     * Don't create a mosquitto user
 > Changes v2-> v3:
 >     * Require BR2_USE_MMU only for the broker
 >         * However there seems to be no real world example of
 >           (!MMU && STATIC_LIBS) in buildroot at the moment
 >     * Remove the dependency on BR2_TOOLCHAIN_HAS_SYNC_4, tested on:
 >         * br-m68k-5208-full.config   [SKIPPED]
 >         * br-m68k-68040-full.config  [OK]
 >         * br-sparc-uclibc.config     [OK]
 >         * br-sparc-uclibc.config     [OK]

Thanks! You are listing the sparc config twice though.

 > +config BR2_PACKAGE_MOSQUITTO_BROKER
 > +	bool "install the mosquitto broker"
 > +	default y
 > +	depends on BR2_USE_MMU # fork()
 > +	depends on BR2_PACKAGE_MOSQUITTO
 > +	help
 > +	  Build and install the mosquitto broker onto target.
 > +
 > +comment "the mosquitto broker needs a system with MMU"
 > +	depends on !BR2_USE_MMU
 > \ No newline at end of file

We normally do not start comments with "the", so I've dropped that and
added a trailing newline.


> diff --git a/package/mosquitto/mosquitto.mk b/package/mosquitto/mosquitto.mk
 > index fcce0535cb..fd36d4452e 100644
 > --- a/package/mosquitto/mosquitto.mk
 > +++ b/package/mosquitto/mosquitto.mk
 > @@ -67,24 +67,30 @@ endef
 >  MOSQUITTO_POST_PATCH_HOOKS += MOSQUITTO_DISABLE_CPP
 >  endif
 
 > +MOSQUITTO_MAKE_DIRS = lib client
 > +ifeq ($(BR2_PACKAGE_MOSQUITTO_BROKER),y)
 > +	MOSQUITTO_MAKE_DIRS += src

We normally do not indent variables (see elsewhere in the same file), so
I've dropped that.

Committed with these minor tweaks and the commit message extended with
the information about why we are dropping the _SYNC_4 dependency, thanks.

-- 
Bye, Peter Korsgaard