[Buildroot] [PATCH v2] pcm-tools: new package

Peter Korsgaard peter at korsgaard.com
Sat Dec 8 09:43:33 UTC 2018


>>>>> "Carlos" == Carlos Santos <casantos at datacom.com.br> writes:

 > Processor Counter Monitor (PCM) is an application programming interface
 > (API) and a set of tools based on the API to monitor performance and
 > energy metrics of Intel(R) Core(TM), Xeon(R), Atom(TM) and Xeon Phi(TM)
 > processors.

 > This package contains a patch on the pmu-query.py script to look for the
 > pcm-core program at the default path. It's not nice to have a Buildroot
 > specific patch but let's use one while we look for a solution that is
 > acceptable upstream.

 > Signed-off-by: Carlos Santos <casantos at datacom.ind.br>
 > ---
 > Supersedes: https://patchwork.ozlabs.org/patch/864801/
 > CC: Romain Naour <romain.naour at gmail.com>
 > CC: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
 > ---
 > Changes v1->v2
 >   - Update to version 201812
 >   - Do not build the test daemon
 >   - Drop the patch on the test daemon, that we don't build
 >   - Drop a patch already applied upstream
 >   - Update the pmu-query.py patch
 >   - Make the changes suggested by Romain Naour and Thomas Petazzoni

 > +config BR2_PACKAGE_PCM_TOOLS
 > +	bool "pcm-tools"
 > +	depends on BR2_i386 || BR2_x86_64
 > +	select BR2_PACKAGE_HWDATA
 > +	select BR2_PACKAGE_HWDATA_PCI_IDS

It is written in C++, so I've added the BR2_INSTALL_LIBSTDCPP dependency
and a comment.


 > +	help
 > +	  Processor Counter Monitor (PCM) is an application programming
 > +	  interface (API) and a set of tools based on the API to monitor
 > +	  performance and energy metrics of Intel(R) Core(TM), Xeon(R),
 > +	  Atom(TM) and Xeon Phi(TM) processors.
 > +
 > +	  Requires a kernel with X86_MSR enabled.

It makes more sense to just forcible enable it in linux.mk if pcm-tools
is enabled, similar to how we do it for other packages.

Committed with these 2 fixes, thanks.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list