[Buildroot] [PATCH v4 3/3] fs/common.mk: make sure that static devices from packages are created
Thomas Petazzoni
thomas.petazzoni at bootlin.com
Wed Dec 5 07:53:11 UTC 2018
Hello,
On Tue, 4 Dec 2018 22:05:19 +0100, Arnout Vandecappelle wrote:
> > diff --git a/fs/common.mk b/fs/common.mk
> > index 077ce8903e..a560417c6c 100644
> > --- a/fs/common.mk
> > +++ b/fs/common.mk
> > @@ -61,10 +61,10 @@ endif
> > $(call PRINTF,$(PACKAGES_PERMISSIONS_TABLE)) > $(ROOTFS_FULL_DEVICES_TABLE)
> > ifneq ($(ROOTFS_DEVICE_TABLES),)
> > cat $(ROOTFS_DEVICE_TABLES) >> $(ROOTFS_FULL_DEVICES_TABLE)
> > +endif
> > ifeq ($(BR2_ROOTFS_DEVICE_CREATION_STATIC),y)
> > $(call PRINTF,$(PACKAGES_DEVICES_TABLE)) >> $(ROOTFS_FULL_DEVICES_TABLE)
> > endif
>
> This is still conflicting with the purpose of patch 2/3: the package device
> tables are still overriding the user-specified global device table.
Fair point. Should we do:
$(call PRINTF,$(PACKAGES_PERMISSIONS_TABLE)) > $(ROOTFS_FULL_DEVICES_TABLE)
ifeq ($(BR2_ROOTFS_DEVICE_CREATION_STATIC),y)
$(call PRINTF,$(PACKAGES_DEVICES_TABLE)) >> $(ROOTFS_FULL_DEVICES_TABLE)
endif
ifneq ($(ROOTFS_DEVICE_TABLES),)
cat $(ROOTFS_DEVICE_TABLES) >> $(ROOTFS_FULL_DEVICES_TABLE)
endif
instead ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
More information about the buildroot
mailing list