[Buildroot] [PATCH] package/libiscsi: add optional dependency to cunit

Yann E. MORIN yann.morin.1998 at free.fr
Tue Dec 4 10:25:00 UTC 2018


libiscsi uses cunit for its test suite, and autodetexcts its presence.

Usually, we just try to disable tests altogether, but there is no way to
do so. So, ensure proper ordering.

Note: there is an ac_cv_have_cunit variable, but it is not a true
ac_cv* cache variable, and the value provided on the command line or
environment is properly ignored.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>

---
Note: for the interesting parties, I've sent a bunch of enhacements to
the configure script upstream:
    https://github.com/sahlberg/libiscsi/pull/283
---
 package/libiscsi/libiscsi.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/libiscsi/libiscsi.mk b/package/libiscsi/libiscsi.mk
index a34069d7bf..2b26a1427c 100644
--- a/package/libiscsi/libiscsi.mk
+++ b/package/libiscsi/libiscsi.mk
@@ -11,6 +11,10 @@ LIBISCSI_LICENSE_FILES = COPYING LICENCE-GPL-2.txt LICENCE-LGPL-2.1.txt
 LIBISCSI_INSTALL_STAGING = YES
 LIBISCSI_AUTORECONF = YES
 
+ifeq ($(BR2_PACKAGE_CUNIT),y)
+LIBISCSI_DEPENDENCIES += cunit
+endif
+
 LIBISCSI_CONF_OPTS = --disable-werror --disable-manpages
 
 # We need to create the m4 directory to make autoreconf work properly.
-- 
2.14.1



More information about the buildroot mailing list