[Buildroot] [PATCH] linux: ensure images/ exist before creatign files there

Matthew Weber Matthew.Weber at collins.com
Mon Dec 3 19:14:48 UTC 2018


All,

On Mon, Dec 3, 2018 at 1:12 PM Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
>
> When using an initramfs, on the first-pass build, we create a dummy cpio
> so that the build succeeeds. The real cpio will come later, and we'll do
> a second-pass build to use the actual cpio.
>
> However, when we touch that dummy cpio, the images/ directory may not
> yet exist, since commit d0f4f95e39 (Makefile: rework main directory
> creation logic) removed its creation at the begining of the build, to
> only at the moment we need it, i.e. during the *_INSTALL_IMAGES_CMDS
> steps.
>
> However, the linux build is not a _INSTALL_IMAGES_CMDS step, so there is
> no guarantee that images/ already exist at that time.
>
> Fix that by explicitly creating images/ before touching the dummy cpio.
>
> Reported-by: Matthew Weber <matthew.weber at rockwellcollins.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Cc: Matthew Weber <matthew.weber at rockwellcollins.com>
> Cc: Thomas Petazzoni <thomas.petazzoni at bootlin.com>

Thanks Yann!

Reviewed-by: Matthew Weber <matthew.weber at rockwellcollins.com>


More information about the buildroot mailing list