[Buildroot] [PATCH 2/2] python-falcon: new package

Grzegorz Blach grzegorz at blach.pl
Wed Aug 29 20:25:30 UTC 2018


On 08/29/2018 09:47 PM, Thomas Petazzoni wrote:
> Hello Joseph,
> 
> On Tue, 28 Aug 2018 09:34:56 -0700, Joseph Kogut wrote:
> 
>> I know python-falcon supports compiling itself using Cython, would it
>> be helpful to do something like:
>>
>> ifeq ($(BR2_PACKAGE_HOST_PYTHON_CYTHON),y)
>> PYTHON_FALCON_DEPENDENCIES += host-cython
>> endif
> 
> I am not very familiar with Cython. How does that work, what does that
> do ? Is it sufficient for Cython to be installed in $(HOST_DIR) to
> allow python-falcon to detect it and use it ?
> 

If BR2_PACKAGE_HOST_PYTHON_CYTHON is enabled in config, Falcon uses 
Cython to compile own code.  Cython on target is not required in this 
case.  Settings PYTHON_FALCON_DEPENDENCIES += host-python-cython
in python-falcon/Config.in also is not required, but may be usable to 
guarantee, that host-python-cython is always installed
before python-falcon.

>> So that if host-cython is selected, python-falcon will utilize it during setup?
>>
>> It might also be helpful to mention in the help text that the package
>> will optionally compile with Cython for enhanced performance, though
>> I'm not sure if that's the Buildroot way of doing things, maybe
>> someone else can chime in.
> 
> Yes, if there are some optional dependencies, we can mention them in
> the package Config.in help text.
> 
> Could you provide a follow-up adding this Cython support in
> python-falcon ?
> 
> Thanks!
> 
> Thomas
> 


More information about the buildroot mailing list