[Buildroot] [PATCH v4 4/4] configs: add linux boot logo to a selection of configs

[Angelo Compagnucci]

Hi Thomas,

On Mon, Aug 27, 2018 at 11:08 AM, Thomas Petazzoni
<thomas.petazzoni at bootlin.com> wrote:
> Hello,
>
> On Fri, 24 Aug 2018 15:45:00 +0200, Angelo Compagnucci wrote:
>> From: Angelo Compagnucci <angelo.compagnucci at gmail.com>
>>
>> This patch adds the buildroot logo as a boot log to a selection of
>> defconfigs.
>>
>> Signed-off-by: Angelo Compagnucci <angelo at amarulasolutions.com>
>
> I won't oppose to this very strongly, but I wanted to voice my opinion
> that I am not sure it is very useful to adjust all those defconfigs to
> make them use the "Buildroot Linux logo".
>
> One aspect of Buildroot that I like a lot is that we don't try to do a
> lot of "integration": we use upstream stuff as-is, and leave it up to
> the Buildroot user to do all the polishing/integration. Having a
> default logo with Buildroot branding goes a bit against this principle.
>
> We'll have a random set of defconfigs using the logo, another random
> set not using the logo. This really doesn't had much value overall.
>
> So I'm very fine with PATCH 1/4 and 2/4 to help people customizing the
> logo. Perhaps 3/4 to have an example logo (but not even sure it is
> that useful), but I'm more skeptical about PATCH 4/4.

No problem dropping it, I initially thought that a sort of branding
could be a nice addition to have.

Sincerely, Angelo

>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com