[Buildroot] [PATCH 3/8] package/mender: add dep on BR2_PACKAGE_UBOOT_TOOLS_FWPRINTENV

Baruch Siach baruch at tkos.co.il
Wed Aug 15 05:08:03 UTC 2018


Hi Mirza,

Mirza Krak writes:
> The Mender client uses fw_printenv/fw_setenv to manipulate the U-boot
> environment, e.g to change the boot candidate after a update has been
> done.
>
> Signed-off-by: Mirza Krak <mirza.krak at northern.tech>
> ---
>  package/mender/Config.in | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/package/mender/Config.in b/package/mender/Config.in
> index e461857486..8c2838c64a 100644
> --- a/package/mender/Config.in
> +++ b/package/mender/Config.in
> @@ -3,6 +3,8 @@ config BR2_PACKAGE_MENDER
>  	depends on BR2_PACKAGE_HOST_GO_ARCH_SUPPORTS
>  	depends on BR2_PACKAGE_HOST_GO_CGO_LINKING_SUPPORTS
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	depends on BR2_PACKAGE_UBOOT_TOOLS
> +	depends on BR2_PACKAGE_UBOOT_TOOLS_FWPRINTENV

For non-obvious dependencies like these we prefer 'select'. Also, since
this is a run-time only dependency, there should be a comment saying
that. So:

      select BR2_PACKAGE_UBOOT_TOOLS # runtime
      select BR2_PACKAGE_UBOOT_TOOLS_FWPRINTENV # runtime

baruch

>  	help
>  	  Mender is an open source over-the-air (OTA) software updater
>  	  for embedded Linux devices. Mender comprises a client

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -


More information about the buildroot mailing list