[Buildroot] [PATCH v3 5/6] zstd: add libzstd support
Peter Seiderer
ps.report at gmx.net
Mon Apr 30 18:48:35 UTC 2018
Hello Yann, Thomas,
On Wed, 25 Apr 2018 23:48:31 +0200, Thomas Petazzoni <thomas.petazzoni at bootlin.com> wrote:
> Hello,
>
> On Mon, 16 Apr 2018 21:39:52 +0200, Peter Seiderer wrote:
> > Add patch to split libzstd install target into pc, static, shared
> > and includes target. Call only the needed ones for the buildroot
> > staging/target install steps (respect the static/shared configuration).
> >
> > Signed-off-by: Peter Seiderer <ps.report at gmx.net>
> > ---
> > Changes v2 -> v3:
> > - split libray install targets for static/shared
> > (suggested by Yann E. MORIN)
>
> Applied to master after implementing the suggestion from Yann:
Thanks for review, suggestions and fixing it on the fly....
>
> [Thomas: as suggested by Yann E. Morin, refactor the build/install
> commands to use only one invocation, with intermediate ZSTD_BUILD_LIBS
> and ZSTD_INSTALL_LIBS variables, defined depending on whether
> static/shared/static+shared is selected.]
>
> Also, did you submit the patch upstream ?
Just done, see [1]...
Regards,
Peter
[1] https://github.com/facebook/zstd/pull/1114
>
> Thanks!
>
> Thomas
More information about the buildroot
mailing list