[Buildroot] [PATCH 2/2] python-watchdog: add missing runtime dependency

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sat Apr 28 21:37:41 UTC 2018


Hello,

On Fri, 16 Feb 2018 14:32:01 +0100, yegorslists at googlemail.com wrote:
> From: Yegor Yefremov <yegorslists at googlemail.com>
> 
> Script watchmedo requires python-setuptools.
> 
> Signed-off-by: Yegor Yefremov <yegorslists at googlemail.com>
> ---
>  package/python-watchdog/Config.in | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/package/python-watchdog/Config.in b/package/python-watchdog/Config.in
> index e529089..18f569e 100644
> --- a/package/python-watchdog/Config.in
> +++ b/package/python-watchdog/Config.in
> @@ -1,8 +1,9 @@
>  config BR2_PACKAGE_PYTHON_WATCHDOG
>  	bool "python-watchdog"
> -	select BR2_PACKAGE_PYTHON_PYYAML
> -	select BR2_PACKAGE_PYTHON_ARGH
> -	select BR2_PACKAGE_PYTHON_PATHTOOLS
> +	select BR2_PACKAGE_PYTHON_ARGH # runtime
> +	select BR2_PACKAGE_PYTHON_PATHTOOLS # runtime
> +	select BR2_PACKAGE_PYTHON_PYYAML # runtime
> +	select BR2_PACKAGE_PYTHON_SETUPTOOLS # runtime

I applied, but since this dependency is only needed for the
watchmedo.py script, does it make sense to make this a mandatory
dependency ?

Also, skimming through the watchmedo.py script, I couldn't see what was
bringing this dependecny on setuptools. Could you enlighten me (it's
mainly for my own curiosity, I trust you when you said it was needed).

Applied, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list