[Buildroot] [git commit] ntp: don't test if the binary exists in the init script

Thomas Petazzoni thomas.petazzoni at bootlin.com
Mon Apr 16 05:34:51 UTC 2018


commit: https://git.buildroot.net/buildroot/commit/?id=e8cd0800aa25a9298c0e58cecbae5a30eabba19d
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

The test doesn't make sense. It just exits without any error if the
binary doesn't exist, which is silly.

Replace the DAEMON variable, which was used only once, by the full path
of the binary file.

Signed-off-by: Carlos Santos <casantos at datacom.ind.br>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
---
 package/ntp/S49ntp | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/package/ntp/S49ntp b/package/ntp/S49ntp
index b4047fceda..35e58746b4 100755
--- a/package/ntp/S49ntp
+++ b/package/ntp/S49ntp
@@ -1,10 +1,6 @@
 #! /bin/sh
 
 NAME=ntpd
-DAEMON=/usr/sbin/$NAME
-
-# Gracefully exit if the package has been removed.
-test -x $DAEMON || exit 0
 
 # Read config file if it is present.
 if [ -r /etc/default/$NAME ]
@@ -15,7 +11,7 @@ fi
 case "$1" in
   start)
     printf "Starting $NAME: "
-    start-stop-daemon -S -q -x $DAEMON -- -g
+    start-stop-daemon -S -q -x /usr/sbin/ntpd -- -g
     [ $? = 0 ] && echo "OK" || echo "FAIL"
     ;;
   stop)


More information about the buildroot mailing list