[Buildroot] [git commit] support/download/dl-wrapper: pass the correct -N option

Thomas Petazzoni thomas.petazzoni at bootlin.com
Thu Apr 12 20:54:00 UTC 2018


commit: https://git.buildroot.net/buildroot/commit/?id=26794449807648284439c6e03a405418d34f523f
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

${raw_name} is never defined in dl-wrapper, and therefore the value
passed to the -N option is always empty. This causes a problem for the
'cvs' backend, which uses the value of this option as the CVS module
to be downloaded.

If the name of the CVS module is omitted, all the CVS modules from
that CVS repository are downloaded, which creates a tarball with a lot
more contents, and the actual useful contents in a sub-directory,
obviously breaking patches that should be applied, and the entire
build process that follows.

Fixes:

  http://autobuild.buildroot.net/results/fcee0e3d7eeeb373313b1794092c729b1b052348/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
Tested-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
Acked-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
---
 support/download/dl-wrapper | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/support/download/dl-wrapper b/support/download/dl-wrapper
index 3d2118a4ef..8d6365e08d 100755
--- a/support/download/dl-wrapper
+++ b/support/download/dl-wrapper
@@ -125,7 +125,7 @@ main() {
                 -c "${cset}" \
                 -d "${dl_dir}" \
                 -n "${raw_base_name}" \
-                -N "${raw_name}" \
+                -N "${base_name}" \
                 -f "${filename}" \
                 -u "${uri}" \
                 -o "${tmpf}" \


More information about the buildroot mailing list