[Buildroot] [PATCH v4 2/8] gst-plugins-${base, good, bad, ugly}: bump to 1.14.0

[Peter Seiderer]

Hello Thomas, Adam,

> Gesendet: Dienstag, 10. April 2018 um 23:40 Uhr
> Von: "Thomas Petazzoni" <thomas.petazzoni at bootlin.com>
> An: "Peter Seiderer" <ps.report at gmx.net>
> Cc: "Adam Duskett" <aduskett at gmail.com>, buildroot at buildroot.org
> Betreff: Re: [Buildroot] [PATCH v4 2/8] gst-plugins-${base, good, bad, ugly}: bump to 1.14.0
>
> Hello Peter,
> 
> Thanks for your feedback!
> 
> On Tue, 10 Apr 2018 18:28:13 +0200, Peter Seiderer wrote:
> 
> > > Indeed, the gst1-plugins-bad package still has a
> > > --enable-wayland/--disable-wayland option:
> > > 
> > > output/build/gst1-plugins-bad-1.14.0 $ ./configure --help | grep wayland
> > >   --disable-wayland            disable wayland sink: wayland  
> > 
> > This is the 'old' one in gstreamer and buildroot and should be kept (NOT moved from bad to base)....
> 
> Not sure to understand what you say here. Do you say: "This option
> already exists in the current version of GStreamer packaged by
> Buildroot, and continues to exist in 1.14.0 and therefore should be
> kept in Buildroot, i.e BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_WAYLAND
> should stay.

I think the BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_WAYLAND could/should
move to base, but the waylandsink enabling BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WAYLAND
should stay in bad....(maybe the confusion comes from the double use of
--enable-wayland option in gst1-plugins-bad enabling wayland support in
libGstGl and/or enabling the waylandsink element)...

>From package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk:

ifneq ($(BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_WAYLAND)$(BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WAYLAND),)
GST1_PLUGINS_BAD_CONF_OPTS += --enable-wayland
GST1_PLUGINS_BAD_DEPENDENCIES += wayland wayland-protocols
else
GST1_PLUGINS_BAD_CONF_OPTS += --disable-wayland
endif


>From package/gstreamer1/gst1-plugins-bad/Config.in:

config BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_WAYLAND
        bool "wayland"
        default y
        depends on BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_EGL
        depends on BR2_PACKAGE_WAYLAND
        select BR2_PACKAGE_WAYLAND_PROTOCOLS
        select BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_HAS_WINDOW
[...]
config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WAYLAND
        bool "wayland"
        default y
        depends on BR2_PACKAGE_WAYLAND
        select BR2_PACKAGE_WAYLAND_PROTOCOLS
        help
          Wayland Video Sink

I get a running waylandsink with:

# BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_WAYLAND is not set
BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WAYLAND=y

> 
> Is that what you meant ?
> 
> > > And in base:
> > > 
> > > output/build/gst1-plugins-base-1.14.0 $ ./configure --help | grep wayland
> > >   --enable-wayland        Enable Wayland support (requires EGL) [default=auto]  
> > 
> > This is the 'new' one in gstreamer, yet without handling in buildroot, enables
> > wayland support in libgstgl (which is used by some plugins, but I believe not
> > by the waylandsink plugin from bad)...
> 
> For this one, do you think we need an explicit
> BR2_PACKAGE_GST1_PLUGINS_BASE_WAYLAND option, or should we just pass
> --enable-wayland as soon as Wayland+EGL are available, in
> gst1-plugins-base.mk ?

Mhh, I believe this is what the old BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_WAYLAND option was,
my first thought was about the automatic solution, but a explicit option named
gst-gl-wayland-support/opengl-wayland-support (?) should be good...

> 
> 
> > > In gst1-plugins-base, the --enable-wayland option requires EGL support,
> > > and will enable some wayland related code in gst-libs/gl/. Peter, do
> > > you understand what this does, compared to the wayland sink provided in
> > > gst1-plugins-bad ?  
> > 
> > Yes, your short analysis is right (and sorry, I can add no more details what
> > is enabled/disabled in the resulting libgstgl library)....
> 
> You *can* add more details, or you *can't* ? :-)

*cant't* (sorry for my bad english ;-) )...

Regards,
Peter

> 
> Best regards,
> 
> Thomas
> -- 
> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>