[Buildroot] [PATCHv2] download/git: more resilient in case of kill

Thomas Petazzoni thomas.petazzoni at bootlin.com
Tue Apr 10 07:36:40 UTC 2018


Hello,

On Mon,  9 Apr 2018 23:56:51 +0200, Yann E. MORIN wrote:
> In case the git backend gets killed right in-between it finished
> initialising the repository, but before it could add the remote,
> we'd end up with a repository without the 'origin' remote, so we
> would not be able to change its URL.
> 
> Another case that may happen (like in the build failure, below),
> is that the repository was initialised with a previous version
> of Buildroot, before the commit e17719264b (download/git: don't
> require too-recent git) was applied, and that trepository was
> still lying around...
> 
> Fixes:
>     http://autobuild.buildroot.org/results/25a/25aae054634368fadb265b97ebe4dda809deff6f/
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Cc: Maxime Hadjinlian <maxime.hadjinlian at gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
> Cc: Peter Korsgaard <peter at korsgaard.com>
> 
> ---
> Changes v1 -> v2:
>   - remove extraneous pushd/popd  (Thomas)
>   - fix if-block condition
> ---
>  support/download/git | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list