[Buildroot] [PATCH 1/2] cramfs: change to new site location

Matthew Weber matthew.weber at rockwellcollins.com
Fri Apr 6 15:38:46 UTC 2018


Thomas,

On Fri, Apr 6, 2018 at 10:13 AM, Thomas Petazzoni
<thomas.petazzoni at bootlin.com> wrote:
> Hello,
>
> On Fri, 6 Apr 2018 15:02:55 +0000, Chris Brandt wrote:
>
>>  > It is missing the new case where the compressed block length is stored
>>  > as an u16 at the beginning of the block. That's pretty much the only use
>>  > of u16 in the code so easy to locate.
>>
>> So then in that case, you would need a bswap_32() and a bswap_16() macro.
>>
>> However...that code is currently inside a "} else if (0) {" block, so it
>> looks like it will never get executed anyway.
>
> I don't see where this else if (0) block is. Where do you see that ?
>
> Matthew: the current patch in Buildroot also fixes cramfsck, but not
> your contribution on the new version of the cramfs tools.
>

Oh good catch, I missed that.  I'll update that in v2 and refresh my
upstream pull request.


More information about the buildroot mailing list