[Buildroot] [PATCH v2 36/37] utils/checkpackagelib: exclude four files from Config.in indentation check
Ricardo Martincoski
ricardo.martincoski at gmail.com
Sun Apr 1 05:08:49 UTC 2018
From: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
package/Config.in, package/Config.in.host, package/x11r7/Config.in and
package/kodi/Config.in do not comply with the normal Config.in
indentation rules. However, this violation of the rule is legitimate, so
let's skip them in check-package for this specific indentation check.
This removes the last 2197 remaining warnings on Config.in files.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
[Ricardo: rebase patch to use relative paths passed by the main script,
fix flake8 warnings, add package/Config.* to the list]
Signed-off-by: Ricardo Martincoski <ricardo.martincoski at gmail.com>
Cc: Yann E. MORIN <yann.morin.1998 at free.fr>
---
NOTE: this patch depends on the first one that introduces the use of
relative paths by the main script when testing intree files.
original patch: http://patchwork.ozlabs.org/patch/849882/
Changes v1 -> v2:
- no changes
---
utils/checkpackagelib/lib_config.py | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/utils/checkpackagelib/lib_config.py b/utils/checkpackagelib/lib_config.py
index 11d885f8c7..1d273f1c5f 100644
--- a/utils/checkpackagelib/lib_config.py
+++ b/utils/checkpackagelib/lib_config.py
@@ -132,6 +132,12 @@ class Indent(_CheckFunction):
text]
elif entry in entries_that_should_not_be_indented:
if not text.startswith(entry):
+ # four Config.in files have a special but legitimate indentation rule
+ if self.filename in ["package/Config.in",
+ "package/Config.in.host",
+ "package/kodi/Config.in",
+ "package/x11r7/Config.in"]:
+ return
return ["{}:{}: should not be indented"
.format(self.filename, lineno),
text]
--
2.14.1
More information about the buildroot
mailing list