[Buildroot] [PATCH 3/3] sdl2: Add KMS/DRM(experimental) video driver support
Arnout Vandecappelle
arnout at mind.be
Tue Sep 26 19:50:05 UTC 2017
On 26-09-17 21:42, Thomas Petazzoni wrote:
> Hello,
>
> On Tue, 26 Sep 2017 21:36:40 +0200, Arnout Vandecappelle wrote:
>
>> XORG7 is a special case, we never select it (and we assume it's obvious that
>> you need X to be able to use X stuff). But if you look at e.g.
>> BR2_PACKAGE_SDL2_X11, it selects BR2_PACKAGE_XLIB_LIBX11 and
>> BR2_PACKAGE_XLIB_LIBXEXT rather than depending on them.
>>
>> BR2_PACKAGE_DIRECTFB should indeed be selected instead of depended on. That's
>> historical accident, because sdl2 was largely copied from sdl, and sdl had this
>> construct since 2009 when there were no clear rules yet about select/depend.
>
> For sdl2, it would be useful to look at the review discussion. I'm
> wondering if I didn't suggest to have a "depends on" for DirectFB, just
> for the sake of having something consistent between the different
> graphics backends. I don't remember.
Nope, it was like that in Guillaume's first submission and nobody commented on it.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
More information about the buildroot
mailing list