[Buildroot] [PATCH 1/1] [RFC] mvebu_espressobin-88f3720 : Add support for espressobin

Maxime Chevallier chevalliersebmax at gmail.com
Tue Sep 26 10:05:13 UTC 2017


Hi,

2017-09-25 23:41 GMT+02:00 Arnout Vandecappelle <arnout at mind.be>:
>
>
> On 25-09-17 23:02, Romain Naour wrote:
>> Hi Maxime,
>>
>> Le 25/09/2017 à 00:05, Maxime Chevallier a écrit :
>>> Add support for the Globalscale 'Espressobin' board based
>>> on Marvell Armada 3720.
>>>
>>> This board has a dual Cortex-A53, 1GB DDR3, USBs, ethernets,
>>> and some GPIO ports. More informations on the vendor site :
>>> http://espressobin.net/tech-spec/
>>>
>>> This config uses the mainline linux support for the board and
>>> the buildroot toolchain using glibc, since uclibc does not
>>> support aarch64.
>>>
>>> Mainline device-tree does not include SDCard support yet, so USB
>>> is the preferred way to boot the image, using the default pre-flashed
>>> u-boot on SPI NOR.
>> Usually we use configs or board in the commit title.
>>
>> "board: Add support for espressobin 88f3720" should be enough.

Ok

>>
>> Otherwise, looks good for me as is.
>
>  Indeed, looks good to me as well.
>
>  I don't like the name much, though. Isn't globalscale_espressobin_defconfig
> more appropriate?

Yes it makes more sense to me, but all support for this board in
u-boot and linux
include 'mvebu' somewhere in the name, so I thought I would do that to.

globalscale_espressobin_defconfig seems less confusing, I will update it in V2.

>>
>> Linux 4.14-rc2 is out, do you know if the SDCard support has been added in this
>> release?

Yes SDCard support has been added in linux 4.14-rc1. When 4.14 comes
out, we will be
able to generate bootable sdcards including the bootloader using
in-tree device-tree.

>> Maybe you can also add a new entry in .gitlab-ci.yml file for CI testing in gitlab.
>> (see .gitlab-ci.yml.in to regenerate this file). But this can be done in a
>> follow up patch.
>
>  No, this is not optional, it *must* be added otherwise we get errors from CI
> (well, except that the gitlab sync is currently broken). Just run
> 'make .gitlab-ci.yml'.

Ok I'll add that in V2.

Thanks for the feedback,

Regards,

Maxime


More information about the buildroot mailing list