[Buildroot] [PATCH] mmc-utils: use upstream provided install target

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Wed Sep 6 21:33:34 UTC 2017


Hello,

On Mon,  4 Sep 2017 10:40:40 +0300, Baruch Siach wrote:
>  define MMC_UTILS_INSTALL_TARGET_CMDS
> -	$(INSTALL) -D -m 0755 $(@D)/mmc $(TARGET_DIR)/usr/bin/mmc
> +	prefix=$(TARGET_DIR) $(MAKE) -C $(@D) install
>  endef

This is not entirely correct, for a few reasons: first, your patch
introduces a difference as the "mmc" program is now installed
in /bin/mmc and not /usr/bin/mmc, which isn't nice.

Also, it mis-uses prefix, as DESTDIR should be used. The correct
use is prefix=/usr (to override the default of /usr/local) and
DESTDIR=$(TARGET_DIR).

Best regards,

Thomas Petazzoni
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


More information about the buildroot mailing list