[Buildroot] [PATCH 1/5] utils/genrandconfig: filter empty lines and comments in CSV file
Yann E. MORIN
yann.morin.1998 at free.fr
Sun Oct 29 17:26:58 UTC 2017
Thomas, All,
On 2017-10-29 18:14 +0100, Thomas Petazzoni spake thusly:
> In preparation for the addition of comments in the CSV file listing
> toolchain configurations, we filter out such lines when reading the
> CSV file in utils/genrandconfig.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
Small nit, below...
> ---
> utils/genrandconfig | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/utils/genrandconfig b/utils/genrandconfig
> index a67d46fad9..e963349d70 100755
> --- a/utils/genrandconfig
> +++ b/utils/genrandconfig
> @@ -126,7 +126,9 @@ def get_toolchain_configs(toolchains_csv, buildrootdir):
> """
>
> with open(toolchains_csv) as r:
> - toolchains = decode_byte_list(r.readlines())
> + # filter empty lines and comments
> + lines = [ t for t in r.readlines() if len(t.strip()) > 0 and t[0] != '#' ]
> + toolchains = decode_byte_list(lines)
> configs = []
>
> (_, _, _, _, hostarch) = os.uname()
> @@ -164,6 +166,7 @@ def get_toolchain_configs(toolchains_csv, buildrootdir):
> with open(configfile) as r:
> config = r.readlines()
> configs.append(config)
> +
Spurious hunk.
Regards,
Yann E. MORIN.
> return configs
>
>
> --
> 2.13.6
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list