[Buildroot] [PATCH v2] nmap: add option to build/install "ncat"

[Thomas Petazzoni]

Hello,

On Tue, 10 Oct 2017 00:08:38 +0200, Arnout Vandecappelle wrote:

> 5. BR2_PACKAGE_NMAP builds nothing, two new options BR2_PACKAGE_NMAP_NMAP and
> BR2_PACKAGE_NMAP_NCAT build nmap resp. ncat. To avoid building nothing, you
> could try something like
> 
> config BR2_PACKAGE_NMAP
> 	select BR2_PACKAGE_NMAP_NCAT if !BR2_PACKAGE_NMAP_NMAP
> 
> if BR2_PACKAGE_NMAP
> config BR2_PACKAGE_NMAP_NMAP
> 	default y
> 
> config BR2_PACKAGE_NMAP_NCAT
> endif
> 
> but that might give a circular dependency.

This option has my preference. And it doesn't have a circular
dependency, we use this construct in several places already.

One example:

config BR2_PACKAGE_ANDROID_TOOLS
        bool "android-tools"
        select BR2_PACKAGE_ANDROID_TOOLS_ADBD if \
              !BR2_PACKAGE_ANDROID_TOOLS_FASTBOOT && \
              !BR2_PACKAGE_ANDROID_TOOLS_ADB

if BR2_PACKAGE_ANDROID_TOOLS

config BR2_PACKAGE_ANDROID_TOOLS_FASTBOOT
        bool "fastboot"

config BR2_PACKAGE_ANDROID_TOOLS_ADB
        bool "adb"

config BR2_PACKAGE_ANDROID_TOOLS_ADBD
        bool "adbd"

endif

However, perhaps we should invert the select:

	select BR2_PACKAGE_NMAP_NMAP if !BR2_PACKAGE_NMAP_NCAT

and drop the "default y" in BR2_PACKAGE_NMAP_NMAP. This way, we still
have "nmap" enabled by default, and now allow the option to select ncat.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com