[Buildroot] [PATCH 1/2] openntpd: fix musl build with older kernel headers

Baruch Siach baruch at tkos.co.il
Fri Oct 6 04:35:15 UTC 2017


Hi Peter,

On Thu, Oct 05, 2017 at 10:17:56PM +0200, Peter Korsgaard wrote:
> >>>>> "Baruch" == Baruch Siach <baruch at tkos.co.il> writes:
> 
>  > musl provides its own SYS_getrandom definition, but not GRND_NONBLOCK.
>  > This breaks the build with kernel headers older than v3.17. Add a patch
>  > adding a local definition of GRND_NONBLOCK to fix the build.
> 
>  > The getentropy_linux.c file is in upstream tarball, but not in its git
>  > repository. It originates form OpenBSD. For this reason the patch is
>  > against the tarball, but not git formatted.
> 
> FYI, I believe upstream openntpd development only supports openbsd,
> similar to E.G. openssh, and the linux specific code is in
> openntpd-portable:
> 
> https://github.com/openntpd-portable/openntpd-portable

The getentropy_linux.c file is not in the openntpd-portable git repo:

  https://github.com/openntpd-portable/openntpd-portable/tree/master/compat

It is apparently copied when generating the tarball from the code openbsd 
libressl:

  https://github.com/libressl-portable/openbsd/blob/master/src/lib/libcrypto/arc4random/getentropy_linux.c

The same goes for libressl-portable, the target of the second patch in this 
series. For that reason the upstream pull request is against the openbsd tree, 
the real upstream for that file.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -


More information about the buildroot mailing list