[Buildroot] [PATCH 1/2] lvm2: add host variant

[Peter Korsgaard]

>>>>> "Arnout" == Arnout Vandecappelle <arnout at mind.be> writes:

 > On 05-10-17 17:06, Peter Korsgaard wrote:
 >> This is only for the device-mapper library, so a user selectable
 >> Config.in.host option isn't needed.
 >> 
 >> Signed-off-by: Peter Korsgaard <peter at korsgaard.com>

 >  I was going to apply, but...

 >> ---
 >> package/lvm2/lvm2.mk | 12 ++++++++++++
 >> 1 file changed, 12 insertions(+)
 >> 
 >> diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
 >> index f7f706976f..5783ab08be 100644
 >> --- a/package/lvm2/lvm2.mk
 >> +++ b/package/lvm2/lvm2.mk
 >> @@ -51,4 +51,16 @@ ifeq ($(BR2_TOOLCHAIN_SUPPORTS_PIE),)
 >> LVM2_CONF_ENV += ac_cv_flag_HAVE_PIE=no
 >> endif
 >> 
 >> +HOST_LVM2_CONF_OPTS = \
 >> +	--enable-write_install \
 >> +	--enable-pkgconfig \

 >  ... this made me think: shouldn't it depend on host-pkgconf? The
 > target package depends on host-pkgconf, even though it doesn't depend
 > on anything else (except optionally readline but that doesn't have a
 > .pc file). It's probably OK but I'd like an explanation just to be
 > sure.

--enable-pkgconfig is about if lvm2 should install .pc files, not if it
should use pkg-config to find dependencies. I had missed the
host-pkgconf dependency on the target variant (because of the +=).
The device-mapper library doesn't strictly need pkg-config, but yeah, it
makes sense to keep in sync with the target version.

I'll add it when applying, thanks!

-- 
Bye, Peter Korsgaard