[Buildroot] [PATCH] pkg-download: make package name optional in github helper

Ismael Luceno ismael at iodev.co.uk
Thu Oct 5 10:13:16 UTC 2017


On 04/Oct/2017 18:35, Arnout Vandecappelle wrote:
<...>
>  The solution (probably) is to use $(PKG) instead of $(pkgname).

I see.

> > +# github(user[,package[,version]]): returns site of GitHub repository
> > +github = https://github.com/$(1)/$(or $(2),$(pkgname))/archive/$(or $(3),$($(call UPPERCASE,$(pkgname))_VERSION))
> 
>  Could you estimate how many packages could be simplified with this?

A great deal, including axel, in 219 out of 380 the repo matches the
package name, with 30 also matching the username.

> I'm not actually sure this is a good idea anyway. The _VERSION is OK
> because it works for *all* packages, the third argument is only needed
> when you use the github helper outside a package (e.g. for a custom
> kernel URL). But this change will apply only to a limited number of
> packages on the one hand, and on the other hand it makes it even more
> difficult for people to understand what is meant with this $(call
> github,foo) construct.

It's "magic" anyway. It would perhaps make sense to implement this kind
of rules via rewriting AXEL_SITE, it could be something descriptive like:

	AXEL_SITE = @ github user:axel-download-accelerator repo:libtls

Here's a mockup: http://tmp.iodev.co.uk/rtest.mk


More information about the buildroot mailing list