[Buildroot] [PATCH] qt5webengine: enable build for 5.6.3

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu Nov 23 19:58:19 UTC 2017


Hello,

Thanks for this contribution! See some comments below.

On Wed, 22 Nov 2017 19:04:02 -0500, Gaël PORTAY wrote:
> Allow to build qt5webengine 5.6.
> 
> Signed-off-by: Gaël PORTAY <gael.portay at savoirfairelinux.com>
> ---
> Hi all,
> 
> The build was broken in 5.6.2 and was disabled.
> 
> Since we upgraded to 5.6.3, buildroot is able to build without backporting
> patches.
> 
> The two additional patches are useful at run-time.
> 
> The first one avoid to specify the path to the SSL certificate directory (using
> an additional environment variable).
> 
> The second one is the same used in 5.9.x (plus resolved conflicts). It uses the
> process's context to get handles on EGLv2 and GLES libraries. Those libraries

EGL and GLESv2

> are linked to Qt WebEngine at compile time.
> 
> The patch is particularly usefull for RPI boards since the raspberrypi userland
> package does not provide the libEGLv2.so.2 and libGLES.so.1 symlinks. Both
> library paths are hardcoded in Qt WebEngine.

Please put all these explanations inside the commit log.

> diff --git a/package/qt5/qt5webengine/5.6.3/0001-change-default-ssl-dir.patch b/package/qt5/qt5webengine/5.6.3/0001-change-default-ssl-dir.patch
> new file mode 100644
> index 0000000000..3e55545eee
> --- /dev/null
> +++ b/package/qt5/qt5webengine/5.6.3/0001-change-default-ssl-dir.patch
> @@ -0,0 +1,19 @@
> +Change the default SSL directory, as buildroot ca-cert package is
> +installed at /etc/ssl. That way, we don't have to use the SSL_CERT_DIR
> +environment at runtime.
> +
> +Upstream-Status: Inappropriate
> +Signed-off-by: Damien Riegel <damien.riegel at savoirfairelinux.com>

Please use Git formatted patches, since Qt is managed with the Git
version control system.

Patch 0002 is correct, but not patch 0001.

Could you send a new version that fixes those issues?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


More information about the buildroot mailing list