[Buildroot] [PATCH 1/1] libupnp: add 1.8.3 version

Fabrice Fontaine fontaine.fabrice at gmail.com
Wed Nov 15 21:04:10 UTC 2017


Dear Thomas,

2017-11-15 13:43 GMT+01:00 Thomas Petazzoni <thomas.petazzoni at free-
electrons.com>:

> Hello,
>
> On Tue, 14 Nov 2017 20:38:21 +0100, Fabrice Fontaine wrote:
>
> > diff --git a/package/libupnp/Config.in b/package/libupnp/Config.in
> > index 7c6c37607..0a8e98c97 100644
> > --- a/package/libupnp/Config.in
> > +++ b/package/libupnp/Config.in
> > @@ -10,5 +10,19 @@ config BR2_PACKAGE_LIBUPNP
> >
> >         http://pupnp.sourceforge.net/
> >
> > +choice
> > +     prompt "libupnp version"
> > +     default BR2_PACKAGE_LIBUPNP_1_6
> > +     help
> > +       Select the version of libupnp API you wish to use.
> > +
> > +config BR2_PACKAGE_LIBUPNP_1_6
> > +     bool "libupnp 1.6.x"
> > +
> > +config BR2_PACKAGE_LIBUPNP_1_8
> > +     bool "libupnp 1.8.x"
> > +
> > +endchoice
>
> I believe we should perhaps instead add a separate libupnp18 package,
> all those "depends on" to decide which package should be visible
> depending on the version of libupnp that is currently selected are a
> bit annoying. But don't rewrite your patch right now: wait for other
> Buildroot developers to give their opinion on this matter.
>
> Is it possible to install both libupnp 1.6 and libupnp 1.8 in the same
> system without any conflict ?
>
Unfortunately no, it was possible in 1.8.0 and 1.8.1 but we had to rollback
due to the vlc developer who wasn't happy with this change:
https://github.com/mrjimenez/pupnp/commit/07f504c61bd9e4d93eb3d373ffc852
7cafe0b9af

>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
>
Best Regards,

Fabrice
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20171115/11ca7dc7/attachment.html>


More information about the buildroot mailing list