[Buildroot] [PATCH 01/14] core: sort packages and eliminate duplicates in show-targets

Yann E. MORIN yann.morin.1998 at free.fr
Sun Nov 12 17:45:39 UTC 2017


Currently, enabling more than one filesystem image will make
'show-targets' list a few host packages more than once.

This is because all filesystem images add the same set of
host-packages to their dependencies, which are then added as-is
to the package list.

Thus, host-fakeroot, host-makedevs and, if needed, host-mkpasswd will
appear as many times as there are filesystem images enabled.

Fix that by sorting the package list, thus eliminating duplicates from
that list. Also sort the rootfs list for good measure. Sort the two
separately, so that rootfses are last.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
Cc: Arnout Vandecappelle <arnout at mind.be>
Cc: Peter Korsgaard <jacmet at uclibc.org>
Reviewed-by: Romain Naour <romain.naour at gmail.com>

---
Changes v1 -> v2:
  - don't toch the variable; just sort the list when dumping it
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 9240d0aeeb..19bfcfbee3 100644
--- a/Makefile
+++ b/Makefile
@@ -789,7 +789,7 @@ legal-info: dirs legal-info-clean legal-info-prepare $(foreach p,$(PACKAGES),$(p
 
 .PHONY: show-targets
 show-targets:
-	@echo $(PACKAGES) $(TARGETS_ROOTFS)
+	@echo $(sort $(PACKAGES)) $(sort $(TARGETS_ROOTFS))
 
 .PHONY: show-build-order
 show-build-order: $(patsubst %,%-show-build-order,$(PACKAGES))
-- 
2.11.0



More information about the buildroot mailing list