[Buildroot] [PATCH v2 1/1] turbovnc: new package

[Baruch Siach]

Hi Stefan,

On Mon, Nov 06, 2017 at 03:13:21PM +0200, Stefan Fröberg wrote:
> 1. TurboVNC really does depend of turbo-jpeg, that's one of the reasons it's
> so fast. So for now I have made it "depends on BR2_PACKAGE_JPEG_TURBO" so 
> that turbovnc package will only appear to menu only if jpeg-turbo has been 
> also selected. Is that okay?

I don't think so.

The manual (§17.2.3) says you should "use a select type of dependency for 
dependencies on libraries", and conversely "use a depends on type of 
dependency when the user really needs to be aware of the dependency". In this 
case there is nothing obvious about having to enable turbo-jpeg for turbovnc, 
IMO.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -