[Buildroot] [PATCH 1/2] jimtcl: explicitly set --host / --build

Peter Korsgaard peter at korsgaard.com
Sun Nov 5 19:49:24 UTC 2017


>>>>> "Arnout" == Arnout Vandecappelle <arnout at mind.be> writes:

 > On 03-11-17 23:28, Peter Korsgaard wrote:
 >> Fixes:
 >> http://autobuild.buildroot.net/results/d13/d137680bf1c0ebfacef635cb2f0fc14524759143/
 >> 
 >> Otherwise the (handwritten) configure script uses a config.guess script from
 >> 2010 to figure out the build host, breaking builds on ppc64le hosts.
 >> 
 >> The result of --host / --build is only used to detect if we are building for
 >> Windows or not, which is why things are working on x86(-64) build hosts
 >> without specifying --host even though we are cross compiling - But this may
 >> change in the future, so we better pass the correct values.
 >> 
 >> Signed-off-by: Peter Korsgaard <peter at korsgaard.com>
 >> ---
 >> package/jimtcl/jimtcl.mk | 2 ++
 >> 1 file changed, 2 insertions(+)
 >> 
 >> diff --git a/package/jimtcl/jimtcl.mk b/package/jimtcl/jimtcl.mk
 >> index cdbf8ae477..313970d94a 100644
 >> --- a/package/jimtcl/jimtcl.mk
 >> +++ b/package/jimtcl/jimtcl.mk
 >> @@ -42,6 +42,8 @@ define JIMTCL_CONFIGURE_CMDS
 >> (cd $(@D); \
 >> $(TARGET_CONFIGURE_OPTS) CCACHE=none \
 >> ./configure --prefix=/usr \
 >> +		--host=$(GNU_TARGET_NAME) \
 >> +		--build=$(GNU_HOST_NAME) \

 >  For consistency with pkg-autotools, perhaps you should specify --target as well?

--target is only for cross compilers, and the configure script (or
rather system.tcl) doesn't accept it:

Error: Unknown option --target
Try: 'configure --help' for options

So committed as is, thanks.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list