[Buildroot] [PATCH] suport/download: force svn to be non-interactive

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Nov 5 15:14:49 UTC 2017


Hello,

On Sun, 5 Nov 2017 15:46:14 +0100, André Hentschel wrote:
> Am 03.11.2017 um 22:22 schrieb Yann E. MORIN:
> > Fixes:
> >     http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
> > 
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> > Cc: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> > Cc: André Hentschel <nerv at dawncrow.de>
> > ---
> >  support/download/svn | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/support/download/svn b/support/download/svn
> > index 77abf3d02d..9f27d71f86 100755
> > --- a/support/download/svn
> > +++ b/support/download/svn
> > @@ -33,6 +33,6 @@ _svn() {
> >      eval ${SVN} "${@}"
> >  }
> >  
> > -_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
> > +_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
> >  
> >  tar czf "${output}" "${basename}"
> >   
> 
> 
> Signed-off-by: André Hentschel <nerv at dawncrow.de>

Such a Signed-off-by doesn't make sense, because you're not passing
the code to someone else. You probably wanted to give one (or several)
of the following:

 - Reviewed-by:
 - Tested-by:
 - Acked-by:

See the manual for the detailed definition of those tags.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


More information about the buildroot mailing list