[Buildroot] [PATCH 1/2] dhcpcd: add SysV start-up script

Arnout Vandecappelle arnout at mind.be
Sun Nov 5 12:18:29 UTC 2017



On 05-11-17 09:10, Yann E. MORIN wrote:
> Arnout, All,
> 
> On 2017-11-04 20:56 +0100, Arnout Vandecappelle spake thusly:
>> On 02-11-17 23:23, Thomas Petazzoni wrote:
>>> Hello,
>>>
>>> On Thu, 2 Nov 2017 23:18:47 +0100, Yann E. MORIN wrote:
>>>
>>>>>  - Same for the configuration file: I prefer a loud error than an init
>>>>>    script that ignores the problem.  
>>>>
>>>> Agreed, too.
>>>>
>>>> However:
>>>>
>>>>   - if the config file is mandatory, then this should be a failure.
>>>>
>>>>   - if the config file is optional, then it missing should be silently
>>>>     ignored and the service started nonetheless.
>>>
>>> So you want explicitly handling for the "missing configuration file"
>>> situation in the init script?
>>>
>>> I wanted to avoid explicit handling, and just let the daemon whine (or
>>> not) if its config file is missing.
>>
>>  I vaguely remember a recently added package where the daemon would silently
>> fail to start if the config file is missing, and which doesn't even have a
>> default config file. So I think checking for existence of the config file in the
>> init script (if the config file is mandatory) makes sense.
> 
> Then it is the responsibility of the package.mk to install one if it is
> mandatory. Otherwise,that means the packaging is incomplete because it
> does not allow the package to work as expected.

 So you mean all packages should do like inadyn: install an example
configuration file even if that is guaranteed not to work.

 Regards,
 Arnout

> 
> And in that case, I side with Thomas' initial suggestion: we should not
> check from the init scripts, because we expect the .mk files to be
> correct.
> 
> Regards,
> Yann E. MORIN.
> 
>>
>>  Regards,
>>  Arnout
>>
>> -- 
>> Arnout Vandecappelle                          arnout at mind be
>> Senior Embedded Software Architect            +32-16-286500
>> Essensium/Mind                                http://www.mind.be
>> G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
>> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
>> GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF


More information about the buildroot mailing list